Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details about .NET 8 IsAotCompatible prop #35755

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Add details about .NET 8 IsAotCompatible prop #35755

merged 2 commits into from
Jun 12, 2023

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jun 12, 2023 •
edited by github-actions bot
Loading

Summary

In this PR:

  • Add details about .NET 8 IsAotCompatible prop
  • Edit pass and cross-ref linking

Fixes #35722

Internal previews

📄 File 🔗 Preview link
docs/core/deploying/native-aot/index.md Native AOT deployment
docs/core/deploying/trimming/prepare-libraries-for-trimming.md Prepare .NET libraries for trimming

@IEvangelist IEvangelist requested a review from adegeo as a code owner June 12, 2023 13:44
@dotnet-bot dotnet-bot added this to the June 2023 milestone Jun 12, 2023
@ghost ghost added the okr-freshness OKR: Freshness of content label Jun 12, 2023
@IEvangelist IEvangelist requested a review from tdykstra June 12, 2023 18:06
tdykstra
tdykstra approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple nits

docs/core/deploying/native-aot/index.md Outdated Show resolved Hide resolved
docs/core/deploying/trimming/prepare-libraries-for-trimming.md Outdated Show resolved Hide resolved
docs/core/deploying/trimming/prepare-libraries-for-trimming.md Outdated Show resolved Hide resolved
docs/core/deploying/trimming/prepare-libraries-for-trimming.md Outdated Show resolved Hide resolved
@IEvangelist IEvangelist enabled auto-merge June 12, 2023 19:34
@IEvangelist IEvangelist merged commit 44aca80 into dotnet:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

@adegeo adegeo Awaiting requested review from adegeo adegeo is a code owner

Assignees
No one assigned
Labels
dotnet-fundamentals/svc okr-freshness OKR: Freshness of content
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

Document IsAotCompatible MSBuild property
3 participants
@IEvangelist @tdykstra @dotnet-bot