Dispose Glfw/Sdl When Checking if Applicable #2352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Calling
GLFW.Glfw.GetApi();
when Glfw is applicable without disposing it leaks the native module. So we make sureDispose()
is called, which triggers freeing of the native library and reduce the 'counter'.Further Comments
This was discovered when I was trying to delete the native library (
glfw3.dll
) on program exit. The delete failed because the program was still referencing the module.The codebase uses the lazy
GlfwProvider.GLFW
where it makes sense. When needed, the lazy implementation will have theDispose()
called, thus freeingglfw3
. But because of the applicable check, the module will never truly be freed without callingGlfwProvider.GLFW.Value._ctx.Dispose();
manually at least once after a Window creation