Fix CI verify stage

[Niicck]

All the molecule tests now pass locally for me. Let's see how it works in CI.

I cleaned up all the lingering bugs with our molecule tests, plus some new bugs that only showed up in the last couple of months.

Resolves: #154

Here's what I did:

• Upgraded molecule test dependencies in requirements.txt
  • Older package versions had some breaking dependency issues around python requests.
  • Also, the schema for adding molecule plugins/drivers had changed.
• Updated supported distros
  • Ubuntu 18.04 is out, 22.04 is in. Also added debian 12.
  • Removing Ubuntu 18.04 fixes an error at the install dokku packages task: can't upgrade to 0.17.1 from 0.16.0 sshcommand#119
• Updated dokku_ports.py
  • The API for managing ports changed with dokku v0.31.0. I put logic in place to handle cases where people haven't upgraded to a version of dokku above 0.31.0
• Replaced depreacted apt_key task
  • https://www.jeffgeerling.com/blog/2022/aptkey-deprecated-debianubuntu-how-fix-ansible
• Updated ansible-lint
• Removed debian10 from our CI pipeline.
  • One of dokku's dependencies was removed from debian10, that's why those builds were failing before: Build of docker-container-healthchecker_0.7.2_arm64.deb is missing for Debian Buster docker-container-healthchecker#129

[ltalirz]

Thanks a lot for this work @Niicck, much appreciated!

All looks good to me, let's see whether you can figure out the dokku package install as well.

By the way, it's not quite clear to me why CI doesn't run on the branch on your fork but it should be possible to get it to run there (then you don't need to wait for me to click the "approve" button on the workflows).

[ltalirz]

this is not your bug but it seems to me, mappings here is never set if no match is found.
could you fix this if you don't mind?

Easiest is just to initialize it to an empty list somewhere further up, then you can also remove the if/else in the non-legacy part

[Niicck]

You know what, mappings = [] was already initialized, I just didn't see it.

https://github.com/dokku/ansible-dokku/pull/166/files#diff-771a074fd2105a1b2651c2dec4070b48246b5ec753f5824031bf3015d07a7f3cR59

[Niicck]

I think you can configure the repo to allow non-maintainers to run workflows: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#allowing-select-actions-and-reusable-workflows-to-run

But I don't think it'll be a blocker. I figured out how to run molecule locally with different distros. So I should be able to identify the rest of the issues without needing to run them in the actual CI pipeline

[Niicck]

Alright, let's give it another run. I think all the distros should be working.

[ltalirz]

I think you can configure the repo to allow non-maintainers to run workflows: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#allowing-select-actions-and-reusable-workflows-to-run

I believe this is about CI running on the upstream repository in the pull request.
You should be able to run the workflows on your fork independently of any settings on the upstream repo.

In any case, the setting is currently

i.e. next time you will no longer be affected.

Thanks a lot for the contribution, much appreciated!