Extension: Manifest v3 #5094
Open
Extension: Manifest v3 #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove that for now, so that the extension at least... loads. Also ignore background document for now
TODO: windows function untested
Was using a private variable
Use it to read and write clipboard content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #5035.
Manifest V3 introduces a number of changes, in particular, background pages need to be replaced by a service worker, and that service worker does not have access to the DOM of the popup page, so we need to switch everything to message passing.
Also, clipboard handling needs to done in a separate offscreen page now (with similar message passing constraints).
Only tested on a Linux laptop, with a hacked together websocket server. This needs to be tested on a Chromebook. kiwi also totally untested.