Merge pull request #668 from BBasile/issue-665

fix #665 - The check for auto function without return doesn't handle "implicit auto functions"
dlang-community · Jun 20, 2018 · 103a327 · 103a327
2 parents 2a565a8 + af25256
commit 103a327
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/dscanner/analysis/auto_function.d b/src/dscanner/analysis/auto_function.d
@@ -49,7 +49,7 @@ public:
 		_returns[$-1] = false;
 
 		const bool autoFun = decl.storageClasses
-			.any!(a => a.token.type == tok!"auto");
+			.any!(a => a.token.type == tok!"auto" || a.atAttribute !is null);
 
 		decl.accept(this);
 
@@ -216,6 +216,16 @@ unittest
 		AutoFunctionChecker.MESSAGE,
 	), sac);
 
+	assertAnalyzerWarnings(q{
+		@property doStuff(){} // [warn]: %s
+		@safe doStuff(){} // [warn]: %s
+		@disable doStuff();
+		@safe void doStuff();
+	}c.format(
+		AutoFunctionChecker.MESSAGE,
+		AutoFunctionChecker.MESSAGE,
+	), sac);
+
 	assertAnalyzerWarnings(q{
 		enum _genSave = "return true;";
 		auto doStuff(){ mixin(_genSave);}