[guides] add Prompting Users to Share Incentivized Links Guide #7342
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advaith1
reviewed
Jan 15, 2025
| const customId = await createPromotionalCustomId(); | ||
|
|
||
| try { | ||
| const { success } = await DiscordRPC.commands.shareLink({ |
There was a problem hiding this comment.
Does this shareLink method display a modal for picking share destinations?
Comment on lines
+916
to
+918
| if (success) { | ||
| // Track successful share for analytics/limiting | ||
| await trackSuccessfulShare(customId); |
There was a problem hiding this comment.
If a user clicks a "copy link" button in the modal but then closes it without doing on-platform sharing, what is the value of success?
There was a problem hiding this comment.
success will be true upon copy
Co-authored-by: advaith <[email protected]>
colinloretz
reviewed
Jan 17, 2025
|
|
||
| When implementing sharing, you'll need to: | ||
| 1. Generate a unique ID for tracking the promotion | ||
| 2. Call the `shareLink` command |
There was a problem hiding this comment.
Linking to the reference will help answer questions like @brad-discord asked below. We can also mention explicitly in the copy. "share the link via a modal".
Suggested change
| 2. Call the `shareLink` command | |
| 2. Call the [`shareLink`](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/sharelink) command |
There was a problem hiding this comment.
we're going to be doing a refresh of these guides and design patterns and will be more heavily linking to the reference
colinloretz
reviewed
Jan 17, 2025
| - Track and validate referrals to prevent abuse | ||
| - Handle edge cases like expired promotions gracefully | ||
| - Consider implementing cool-down periods between shares | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.