wip parry_to_bevy_mesh #628
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
force-pushed
the
mesh_parry_to_bevy
branch
from
596f9ea to
9dfe1f5
Compare
Vrixyz
commented
Jan 17, 2025
Vrixyz
commented
Jan 17, 2025
| } | ||
| #[cfg(feature = "dim2")] | ||
| rapier::prelude::TypedShape::RoundConvexPolygon(round_shape) => { | ||
| // FIXME: parry doesn't have easy to use functions to convert RoundShapes to a mesh. |
There was a problem hiding this comment.
that's missing for to_trimesh module
Vrixyz
commented
Jan 17, 2025
github-merge-queue bot
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Jan 23, 2025
# Objective Make `Mesh::merge` more resilient to use. Currently, it's difficult to make sure `Mesh::merge` will not panic (we'd have to check if all attributes are compatible). - I'd appreciate it for utility function to convert different mesh representations such as: dimforge/bevy_rapier#628. ## Solution - Make `Mesh::merge` return a `Result`. ## Testing - It builds ## Migration Guide - `Mesh::merge` now returns a `Result<(), MeshMergeError>`. --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Greeble <[email protected]> Co-authored-by: Benjamin Brienen <[email protected]>
Vrixyz
commented
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord discussion https://discordapp.com/channels/507548572338880513/748627261384556715/1314267962668220447