Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popescu #16

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Popescu #16

wants to merge 31 commits into from

Conversation

AndreaPopescu
Copy link
Collaborator

@AndreaPopescu AndreaPopescu commented Oct 27, 2022

Guardare LandingPage-1 e Style.css
Ho fatto il Content-area-hero e footer

@dianaberna
Copy link
Owner

feedback esercizi html/css

LandingPage-1 👍
LandingPage-2 👍 ottimo che hai utilizzato le variabili css
Portfolio-site 👍 attenzione quando hai delle immagini meglio non averle come svg ma come png/jpeg o webp mentre le icone come svg

Non ho trovato html/css di qualche schermata mobile 🧐

per i nomi delle classi cerca di utilizzare sempre la stessa lingua (sarebbe ottimo sempre l'inglese)

@AndreaPopescu
Copy link
Collaborator Author

AndreaPopescu commented Nov 13, 2022 via email

@AndreaPopescu
Copy link
Collaborator Author

AndreaPopescu commented Nov 13, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants