ci: Bump CI versions #1082
Open
ci: Bump CI versions #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: 0 B Total Size: 65.8 kB ℹ️ View Unchanged
|
Draft
rschristian
commented
Jun 4, 2024
Comment on lines
-6
to
+7
| branches-ignore: | ||
| - trying.tmp | ||
| - staging.tmp | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
Limiting to master else a PR gets a CI run from both push and & pull_request triggers
| @@ -43,7 +42,7 @@ describe('fixtures', () => { | |||
|
|
|||
| await sleep(1); | |||
|
|
|||
| const output = await buildDirectory(fixtureDir); | |||
There was a problem hiding this comment.
Unfortunately we need to drop this aspect of the suite. gzip & brotli sizes aren't guaranteed to be stable, not through Node versions or on different systems. As such, I was seeing tests pass locally that would then be 1-2b off on the CI.
Besides, all that this aspect was testing was that the gzip & brotli size estimates were stable, which isn't particularly important -- what matters is that the expected output is stable. Gzip/brotli sizes are just derived values & not meaningfully actionable.
There was a problem hiding this comment.
hmmm do we get any reporting on the size then?
I guess compressed size action?
There was a problem hiding this comment.
Compressed Size, yeah.
It's not ideal but I don't have any other ideas for how to deal with this.
|
Will then need the required CIs to be updated Edit: Not an admin so I can't do it myself |
ForsakenHarmony
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.