Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20241125 token user override #993

Merged
merged 9 commits into from
Dec 18, 2024
Merged

20241125 token user override #993

merged 9 commits into from
Dec 18, 2024

Conversation

peterthomassen
Copy link
Member

@peterthomassen peterthomassen commented Nov 29, 2024 •
edited
Loading

This implements #886.

@peterthomassen peterthomassen force-pushed the 20241125_token_user_override branch 4 times, most recently from 607e2f0 to f01192b Compare December 7, 2024 01:02
@peterthomassen peterthomassen marked this pull request as ready for review December 8, 2024 00:14
@peterthomassen
Copy link
Member Author

peterthomassen commented Dec 8, 2024 •
edited
Loading

View adjustments, tests, and docs done -- ready for review.

(Might add some more tests, e.g.: setting user_override on POST tokens/ has no effect; make a DNS change with an override token; access an override token's policy from owner or override account.) (done)

@peterthomassen
Copy link
Member Author

peterthomassen commented Dec 13, 2024 •
edited
Loading

Final part has been added, with the workflow from #858 now fully functioning.

Missing:

  • nicer text (warnings) in email template and activation GUI
  • tests for 237ebd9 (will be added as a fixup)
  • docs for the sign-up related functionality (will not document for now; prefer to add in January or so when we know the API is stable)

@peterthomassen peterthomassen requested review from nils-wisiol and removed request for nils-wisiol December 13, 2024 12:08
nils-wisiol
nils-wisiol reviewed Dec 15, 2024
View reviewed changes
Copy link
Contributor

@nils-wisiol nils-wisiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments but haven't looked at all commits yet. Commented 'revisit' for things we need to look at together.

api/desecapi/permissions.py Outdated Show resolved Hide resolved
docs/auth/tokens.rst Outdated Show resolved Hide resolved
docs/auth/tokens.rst Show resolved Hide resolved
api/desecapi/views/domains.py Outdated Show resolved Hide resolved
api/desecapi/views/tokens.py Show resolved Hide resolved
@peterthomassen peterthomassen force-pushed the 20241125_token_user_override branch 5 times, most recently from 4a3df30 to 7bb4c84 Compare December 17, 2024 19:20
nils-wisiol
nils-wisiol approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@nils-wisiol nils-wisiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, three nits found

docs/auth/tokens.rst Show resolved Hide resolved
api/desecapi/templates/emails/activate-account-with-override-token/content.txt Outdated Show resolved Hide resolved
api/desecapi/views/authenticated_actions.py Outdated Show resolved Hide resolved
@peterthomassen peterthomassen force-pushed the 20241125_token_user_override branch from 7bb4c84 to 3beb337 Compare December 18, 2024 12:55
@peterthomassen peterthomassen force-pushed the 20241125_token_user_override branch from 3beb337 to f910d62 Compare December 18, 2024 13:33
@peterthomassen peterthomassen merged commit f910d62 into main Dec 18, 2024
5 checks passed
@peterthomassen peterthomassen deleted the 20241125_token_user_override branch December 18, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nils-wisiol nils-wisiol nils-wisiol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterthomassen @nils-wisiol