Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clarify missing file error message #221

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

goller
Copy link
Collaborator

@goller goller commented Nov 1, 2023

The error returned from buildkit was confusing.
This simplifies the error message to the useful
details.

Previous:

 => ERROR [5/5] COPY howdy /doody                                                                                     0.0s
------
 > [5/5] COPY howdy /doody:
------

Error: failed to solve: failed to compute cache key: failed to calculate checksum of ref vv3yzwr47shug36z88iqkt7yq::l6be4rvphai7t4cl6oyb2j8mu: "/howdy": not found

Now:

 => ERROR [5/5] COPY howdy /doody                                                                                     0.0s
------
 > [5/5] COPY howdy /doody:
------

Error:  "/howdy": not found. Please check if the files exist in the context.

Copy link
Member

@jacobwgillespie jacobwgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💥

I'm torn between what you have here, where we replace the confusing error with the friendly one, or something where we add the friendly interpretation before or after the existing message, in case somebody's familiar with BuildKit errors.

At the moment, I think what you have makes sense to me, because idk if anybody is actually depending on the original error message, and the new one is way clearer

The error returned from buildkit was confusing.
This simplifies the error message to the useful
details.

Signed-off-by: Chris Goller <[email protected]>
@goller goller force-pushed the feat/simplify-missing-file-error branch from baf6454 to 2972eb9 Compare November 14, 2023 14:26
@goller goller merged commit 7aef753 into main Nov 14, 2023
6 checks passed
@goller goller deleted the feat/simplify-missing-file-error branch November 14, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants