WIP statsd metrics eps appointments #20335
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
96415_statsd_eps_appointments/main/main
va-vfs-bot
temporarily deployed
to
96415_statsd_eps_appointments/main/main
lee-delarm6
requested changes
Jan 17, 2025
| unless response.status == 200 | ||
| # log failures | ||
| StatsD.increment(STATSD_KEY, tags: ["failures:#{response.body}"]) | ||
| end |
There was a problem hiding this comment.
Since the same code is used, could this be extracted to a method like
def track_metric(key, tag)
StatsDMetric.new(key: key).save
StatsD.increment(key, tags: [tag])
endand then just do:
track_metric(STATSD_KEY, 'get_appointments call completed')(or whatever the tag is)
| StatsD.increment(STATSD_KEY, tags: ['create_draft_appointment call completed']) | ||
| unless response.status == 200 | ||
| # log failures | ||
| StatsD.increment(STATSD_KEY, tags: ["failures:#{response.body}"]) |
There was a problem hiding this comment.
Not sure we can log the response body if it had private data in it, but it might be totally fine. It's obviously very useful. Question for @randomsync or @kanchanasuriya
va-vfs-bot
temporarily deployed
to
96415_statsd_eps_appointments/main/main
| @@ -10,6 +12,13 @@ class AppointmentService < BaseService | |||
| def get_appointments | |||
| response = perform(:get, "/#{config.base_path}/appointments?patientId=#{patient_id}", | |||
| {}, headers) | |||
|
|
|||
| track_metric(STATSD_KEY, 'get_appointments call completed') | |||
There was a problem hiding this comment.
Could you please see if we can make use of existing vaos_logging middleware?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done