-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CC Referral Appointments - Draft Appointment Submit #20323
Open
devin-mccurdy
wants to merge
6
commits into
master
Choose a base branch
from
98251_draft_appointment_submit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
January 16, 2025 20:01
Inactive
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
January 16, 2025 20:33
Inactive
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
January 16, 2025 20:59
Inactive
devin-mccurdy
force-pushed
the
98251_draft_appointment_submit
branch
from
January 16, 2025 21:30
97208ba
to
eeb109a
Compare
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
January 16, 2025 21:31
Inactive
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
January 16, 2025 22:10
Inactive
github-actions
bot
added
require-backend-approval
test-failure
and removed
test-passing
labels
Jan 17, 2025
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
January 17, 2025 15:39
Inactive
@devin-mccurdy this PR has a failing test |
Whoops, last minute update to match the draft serializer PR and missed that I'd also need to update that test |
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
January 17, 2025 16:29
Inactive
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
January 17, 2025 17:08
Inactive
github-actions
bot
added
test-passing
ready-for-backend-review
and removed
test-failure
labels
Jan 17, 2025
stevenjcumming
requested changes
Jan 17, 2025
@@ -323,6 +346,57 @@ def create_method_logging_name | |||
APPT_CREATE_VAOS | |||
end | |||
end | |||
|
|||
# rubocop:disable Metrics/MethodLength | |||
def submit_params |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the MethodLength warning
consider using address params to another method
def submit_params
# omit
params.permit(
address: address_params
#omit
end
def address_params
[
:type,
{ line: [] },
:city,
:state,
:postal_code,
:country,
:text
]
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This work is behind a feature toggle (flipper): NO - this is a new endpoint and not behind a backend feature flag.
Add a new route to the VAOS module that submits CC referral draft appointments to EPS. The submission doesn't return any useful data other than the
201
response.Related issue(s)
Testing done
Screenshots
N/A
What areas of the site does it impact?
VAOS module
Acceptance criteria