Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC Referral Appointments - Draft Appointment Submit #20323

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

devin-mccurdy
Copy link
Contributor

@devin-mccurdy devin-mccurdy commented Jan 16, 2025

Summary

  • This work is behind a feature toggle (flipper): NO - this is a new endpoint and not behind a backend feature flag.

  • Add a new route to the VAOS module that submits CC referral draft appointments to EPS. The submission doesn't return any useful data other than the 201 response.

Related issue(s)

Testing done

  • New code is covered by unit tests

Screenshots

N/A

What areas of the site does it impact?

VAOS module

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)

@devin-mccurdy devin-mccurdy force-pushed the 98251_draft_appointment_submit branch from 97208ba to eeb109a Compare January 16, 2025 21:30
@va-vfs-bot va-vfs-bot temporarily deployed to 98251_draft_appointment_submit/main/main January 16, 2025 21:31 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98251_draft_appointment_submit/main/main January 16, 2025 22:10 Inactive
@devin-mccurdy devin-mccurdy marked this pull request as ready for review January 17, 2025 15:37
@devin-mccurdy devin-mccurdy requested review from a team as code owners January 17, 2025 15:37
@va-vfs-bot va-vfs-bot temporarily deployed to 98251_draft_appointment_submit/main/main January 17, 2025 15:39 Inactive
@stevenjcumming
Copy link
Contributor

@devin-mccurdy this PR has a failing test

@devin-mccurdy
Copy link
Contributor Author

@devin-mccurdy this PR has a failing test

Whoops, last minute update to match the draft serializer PR and missed that I'd also need to update that test

@va-vfs-bot va-vfs-bot temporarily deployed to 98251_draft_appointment_submit/main/main January 17, 2025 16:29 Inactive
@@ -323,6 +346,57 @@ def create_method_logging_name
APPT_CREATE_VAOS
end
end

# rubocop:disable Metrics/MethodLength
def submit_params
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the MethodLength warning

consider using address params to another method

def submit_params
  # omit
  params.permit(
    address: address_params
  #omit
end

def address_params
  [
    :type,
    { line: [] },
    :city,
    :state,
    :postal_code,
    :country,
    :text
  ]
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants