Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2131 - Upgrade pyjwt #2236

Merged
merged 5 commits into from
Jan 9, 2025
Merged

#2131 - Upgrade pyjwt #2236

merged 5 commits into from
Jan 9, 2025

Conversation

MackHalliday
Copy link

@MackHalliday MackHalliday commented Jan 7, 2025

Description

issue #2131

Looked into errors being thrown by updating PyJWT to 2.10.1.

Decided ignoring validation of 'sub' not did not pose any security risk and implemented suggestion from user story to disable verification -> Adding config JWT_VERIFY_SUB = False.

Resources

How Has This Been Tested?

  • Added constant to Config class.
  • Update pyjwt to latest version in poetry.
  • Confirm testing passes and deploy OK.

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@MackHalliday MackHalliday self-assigned this Jan 9, 2025
@MackHalliday MackHalliday marked this pull request as ready for review January 9, 2025 16:23
@MackHalliday MackHalliday requested a review from a team as a code owner January 9, 2025 16:23
@MackHalliday MackHalliday added patch and removed minor labels Jan 9, 2025
@k-macmillan k-macmillan merged commit 7f37ff9 into main Jan 9, 2025
5 checks passed
@k-macmillan k-macmillan deleted the 2131-upgrade-pyjwt branch January 9, 2025 16:44
@cris-oddball cris-oddball changed the title 2131 - Upgrade pyjwt #2131 - Upgrade pyjwt Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants