Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable locking available ships - added reduce credit at start of startProject event and in catch handling revert the available ships #28

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enable locking available ships - added reduce credit at start of startProject event and in catch handling revert the available ships #28

wants to merge 4 commits into from

Conversation

PREMPRAKASHSINGH
Copy link
Contributor

@PREMPRAKASHSINGH PREMPRAKASHSINGH commented Aug 13, 2024 •
edited
Loading

Closes #14

  • Added reduce available ship in startProject event.
  • Added a catch handling to revert the available ships in case of any error.
  • Commented the code for reduce available credits in handleOnboardingToolUse function which used to run at project completed status

@PREMPRAKASHSINGH PREMPRAKASHSINGH mentioned this pull request Aug 13, 2024
Open
ptmaroct
ptmaroct requested changes Aug 16, 2024
View reviewed changes
server/controllers/onboardingToolController.js Outdated
await updateUserProfile(userId, profilePayload);
}

// removing deduct available ships from here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the unused code instead of committing, rest looks good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed commented code. Please review now.

@PREMPRAKASHSINGH
Copy link
Contributor Author

@ptmaroct Cleaned up the commented code. Please check.

@PREMPRAKASHSINGH
Copy link
Contributor Author

@ms4n @ptmaroct resolved conflicts, please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptmaroct ptmaroct ptmaroct requested changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable locking available ships
2 participants
@PREMPRAKASHSINGH @ptmaroct