Remove generated go code before regeneration
#928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #927, we've seen that the go-linter is failing. The reason being that some of the files did not update their version from
v2024tov2025in the yearly update PR (#925). After closer inspection, it seems like the code generation is non-determistic. While the version of the code-generator is pinned to a specific tag (here), there seem to be some loose dependencies which cause this. The root problem was that some files did not get regenerated (but also not deleted), thus, their version was not updated.I didn't have the time to look further into the non-determinism of the issue, but made sure that this won't happen again by first removing the generated code before regeneration. The files that did not get regenerated in this version (the
client/applyconfigurationsubmodule) should not be too important.Closes #927