Run health.yaml for bots (#222)

* Run `health.yaml` for bots * Remove unused tag * Fix coverage * Add entry to changelog
dart-lang · Jan 10, 2024 · d7aaecb · d7aaecb
1 parent 971c733
commit d7aaecb
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 13 deletions.
diff --git a/pkgs/firehose/CHANGELOG.md b/pkgs/firehose/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.5.2
+
+- Also run health workflows on bot PRs.
+- Fix coverage handling on monorepos.
+
 ## 0.5.1
 
 - Fix comment ID serialization to disk.

diff --git a/pkgs/firehose/lib/src/health/coverage.dart b/pkgs/firehose/lib/src/health/coverage.dart
@@ -58,11 +58,14 @@ class Coverage {
           .where((element) => element.name == package.name)
           .firstOrNull;
       final oldCoverages = getCoverage(basePackage);
-      for (var file in filesOfInterest.map((file) => file.relativePath)) {
-        var oldCoverage = oldCoverages[file];
-        var newCoverage = newCoverages[file];
-        print('Compage coverage for $file: $oldCoverage vs $newCoverage');
-        coverageResult[file] = Change(
+      var filePaths = filesOfInterest
+          .where((file) => file.isInPackage(package))
+          .map((file) => file.relativePath);
+      for (var filePath in filePaths) {
+        var oldCoverage = oldCoverages[filePath];
+        var newCoverage = newCoverages[filePath];
+        print('Compage coverage for $filePath: $oldCoverage vs $newCoverage');
+        coverageResult[filePath] = Change(
           oldCoverage: oldCoverage,
           newCoverage: newCoverage,
         );

diff --git a/pkgs/firehose/lib/src/health/health.dart b/pkgs/firehose/lib/src/health/health.dart
@@ -20,8 +20,6 @@ import 'changelog.dart';
 import 'coverage.dart';
 import 'license.dart';
 
-const String _botSuffix = '[bot]';
-
 const String _publishBotTag2 = '### Package publish validation';
 
 const String _licenseBotTag = '### License Headers';
@@ -66,11 +64,6 @@ class Health {
     if (!expectEnv(github.issueNumber?.toString(), 'ISSUE_NUMBER')) return;
     if (!expectEnv(github.sha, 'GITHUB_SHA')) return;
 
-    if ((github.actor ?? '').endsWith(_botSuffix)) {
-      print('Skipping package validation for ${github.actor} PRs.');
-      return;
-    }
-
     print('Start health check for the check $check');
     print('Checking for $check');
     if (!github.prLabels.contains('skip-$check-check')) {

diff --git a/pkgs/firehose/pubspec.yaml b/pkgs/firehose/pubspec.yaml
@@ -1,6 +1,6 @@
 name: firehose
 description: A tool to automate publishing of Pub packages from GitHub actions.
-version: 0.5.1
+version: 0.5.2
 repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose
 
 environment: