Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nav optimazation #5785

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: nav optimazation #5785

wants to merge 7 commits into from

Conversation

berry-13
Copy link
Collaborator

@berry-13 berry-13 commented Feb 10, 2025

Summary

Backend Changes:

  • 🔍 Refactor Pagination: Transitioned from page-based to cursor-based pagination. The method getConvosByPage is now getConvosByCursor in api/models/Conversation.js, enabling seamless data fetching with cursor control
  • Enhance Query Handling: Updated getConvosQueried to accommodate cursor-based logic, refining conversation filtering and sorting based on cursors
  • 🔗 Route Adjustments: Modified api/server/routes/convos.js to align with cursor pagination, updating relevant request parameters [1] [2]
  • 🔄 Search Route Update: Adjusted api/server/routes/search.js to incorporate cursor-based pagination for a streamlined response structure

Frontend Changes:

  • 📦 Dependency Update: Enhanced client/package.json with utilities for virtualized list rendering and lodash enhancements. [1] [2] [3]
  • 🚀 UI Enhancement: Upgraded Conversations component to implement react-virtualized, optimizing the rendering of large lists
  • 🛠️ Refactored TypeScript Integration: Refactored Convo component using TypeScript interfaces, refining state management for better handling of conversation title updates

This PR significantly improves data management efficiency and enhances the user interface for a more responsive application experience

Change Type

  • a11y
  • Performance

Testing


Test Configuration:

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@berry-13 berry-13 marked this pull request as draft February 10, 2025 16:52
@berry-13 berry-13 force-pushed the feat/nav-optimization branch from 20c7df2 to 7c77847 Compare February 10, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant