Add the ability to fallback to a primary locale #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustin
commented
Nov 14, 2024
| context "when Chinese is available" do | ||
| let(:available_langtag) { "zh" } | ||
|
|
||
| it { expect(best_match).to eq "zh" } |
There was a problem hiding this comment.
This is the case that's being handle by this change
…f that is explicitly requestes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cyril thanks for the work on this gem!
I'm opening this PR, but not sure if this is something that you would be interested to add into the gem. The idea of this change is to be able to fallback to a primary language locale if an extra argument is passed to the
.matchmethod, and in that case if all the preferred locales doesn't match with the available locales, a last attempt is made to match a primary locale.Let me know if you have any concerns or comments about it!
Many thanks!