-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand comma separated lists in global.cylc:[install][symlink dirs]
#6475
Open
wxtim
wants to merge
5
commits into
cylc:master
Choose a base branch
from
wxtim:feature.commas-in-install_target_sections
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Expand comma separated lists in global.cylc:[install][symlink dirs]
#6475
wxtim
wants to merge
5
commits into
cylc:master
from
wxtim:feature.commas-in-install_target_sections
+72
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
approved these changes
Nov 13, 2024
wxtim
force-pushed
the
feature.commas-in-install_target_sections
branch
from
November 13, 2024 09:24
872d2cb
to
b802589
Compare
wxtim
force-pushed
the
feature.commas-in-install_target_sections
branch
from
November 13, 2024 10:14
48a11e3
to
a1ad268
Compare
wxtim
force-pushed
the
feature.commas-in-install_target_sections
branch
from
November 13, 2024 10:16
a1ad268
to
8564aaf
Compare
MetRonnie
reviewed
Nov 13, 2024
wxtim
commented
Nov 14, 2024
wxtim
commented
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From an issue raised by @dpmatthews
Allow comma separated lists of install targets in
global.cylc:[install][symlink dirs][__MANY__]
@oliver-sanders tagged for code review, @dpmatthews for concept review.
Note
Slightly cheekily, I've targeted 3.8.x not master. Although this is a feature, it's for sysadmins not end-users, and I have very high confidence that it won't break anything.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).?.?.x
branch.