Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand comma separated lists in global.cylc:[install][symlink dirs] #6475

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Nov 12, 2024

From an issue raised by @dpmatthews

Allow comma separated lists of install targets in global.cylc:[install][symlink dirs][__MANY__]

@oliver-sanders tagged for code review, @dpmatthews for concept review.

Note

Slightly cheekily, I've targeted 3.8.x not master. Although this is a feature, it's for sysadmins not end-users, and I have very high confidence that it won't break anything.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim force-pushed the feature.commas-in-install_target_sections branch from 872d2cb to b802589 Compare November 13, 2024 09:24
@wxtim wxtim force-pushed the feature.commas-in-install_target_sections branch from 48a11e3 to a1ad268 Compare November 13, 2024 10:14
@wxtim wxtim requested a review from MetRonnie November 13, 2024 10:15
@wxtim wxtim force-pushed the feature.commas-in-install_target_sections branch from a1ad268 to 8564aaf Compare November 13, 2024 10:16
@wxtim wxtim self-assigned this Nov 13, 2024
cylc/flow/network/schema.py Outdated Show resolved Hide resolved
cylc/flow/network/schema.py Outdated Show resolved Hide resolved
@wxtim wxtim requested a review from MetRonnie November 14, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants