Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isodatetime to 3.2 #5928

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Jan 16, 2024

Fix bug where next(...) could return a datetime in the past. E.g. if the current time is 2024-01-01T12:30Z, next(--01-01) now evaluates to 2025-01-01T00:00Z instead of 2024-01-01T00:00Z. Equivalent fix for previous().

Closes #5795
Also addresses #4805 (already closed)

Does not tackle #2382

Needs:

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Fix example for previous() for isodatetime 3.2 cylc-doc#713
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added bug Something is wrong :( dependencies labels Jan 16, 2024
@MetRonnie MetRonnie added this to the cylc-8.3.0 milestone Jan 16, 2024
@MetRonnie MetRonnie self-assigned this Jan 16, 2024
@MetRonnie MetRonnie marked this pull request as draft January 16, 2024 17:25
@hjoliver hjoliver modified the milestones: cylc-8.3.0, cylc-8.4.0 Mar 14, 2024
@oliver-sanders oliver-sanders modified the milestones: 8.4.0, 8.x Jul 9, 2024
Fix bug where `next(...)` could return past datetime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next() can return a datetime that is in the past
3 participants