Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename ActiveRecord::transact to ActiveRecord::groupActions #34

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Dec 20, 2024

🔍 What was changed

Renamed AR::transact() to AR::groupActions()
Added the new AR::transact that really opens a DB transaction on call

📝 Checklist

📃 Documentation

cycle/docs@12394f9

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.71%. Comparing base (4f4a952) to head (a0d373e).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
+ Coverage     83.47%   86.71%   +3.24%     
- Complexity       39       43       +4     
============================================
  Files             8        8              
  Lines           115      128      +13     
============================================
+ Hits             96      111      +15     
+ Misses           19       17       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit 7b6539b into master Dec 20, 2024
16 of 19 checks passed
@roxblnfk roxblnfk deleted the transact branch December 20, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: replace ::transact() with ::group()
1 participant