Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking to use hloc for following usecase which is not uncommon in vision-based localization:
However, I think the examples provided don't directly address this usecase, as they are mostly written to evaluate hloc on datasets. As a result, the reference images and query images are tightly coupled. For example, in
pipeline_Aachen.ipynb
, the features for both the reference and query images are extracted together. Localizing query images wihtout updating the ground-truth data (eg. features db) requires changing the code.While the notebook
demo.ipynb
achieves something to this effect, it uses exhaustive matching which is impractical for most usecases.I have added
pipeline_custom.ipynb
that demonstrates how to use hloc for one's own data (with some very small changes to the hloc APIs).If this is useful, I can add more documentation on how to generate one's own data (eg. generating colmap SfM model) if needed.