Test autosaving of gamma correction setting #9124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 19, 2025 14:43
added 2 commits
February 20, 2025 11:49
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9124 +/- ##
========================================
Coverage 73.83% 73.83%
========================================
Files 431 431
Lines 44807 44804 -3
Branches 3892 3892
========================================
- Hits 33084 33082 -2
+ Misses 11723 11722 -1
|
klakhov
reviewed
Feb 21, 2025
tests/cypress/e2e/actions_tasks/case_68_saving_settings_local_storage.js
Show resolved
Hide resolved
tests/cypress/e2e/actions_tasks/case_68_saving_settings_local_storage.js
Outdated
Show resolved
Hide resolved
klakhov
reviewed
Feb 21, 2025
| @@ -3,12 +3,33 @@ | |||
| // | |||
| // SPDX-License-Identifier: MIT | |||
|
|
|||
| /// <reference types="cypress" /> | |||
| /// / <reference types="../../support/index.d.ts" /> | |||
There was a problem hiding this comment.
This type file is not implemented yet
tests/cypress/plugins/index.js
Outdated
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| /// <reference types="cypress" /> | |||
|
|
|||
| /* eslint security/detect-non-literal-fs-filename: 0 */ | |||
There was a problem hiding this comment.
Will /* eslint-disable security/detect-non-literal-fs-filename */ work?
Looks a bit cleaner than : 0
There was a problem hiding this comment.
Yes, that works. Applied
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update existing local storage test to include gamma setting checks.
Motivation and context
This is a test for storing gamma correction value alongside other settings inside
localStorage.Thanks to #9032, gamma is treated separately from other color settings. Unlike brightness, contrast and saturation settings, which change style attributes on
#cvat_canvas_background, gamma is stored insidelocalStorage.clientSettings.imageFilterentity. This was the main motivation of updating thecase_68_saving_settings_local_storage.jsinstead of writing a new testcase or updating the color settings test.How has this been tested?
The main flow of the test stayed the same, but with couple of changes. Validation and setup parts were extended to include gamma.
Before the changes the test looked like this:
localStorageis setNow, gamma is set up before step 1 and validated after first reload. Also, color settings are reset after the gamma check to keep integrity between tests
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.