Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for the GET /api/tasks/<id>/status API #9076

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Feb 7, 2025

Motivation and context

The GET /api/tasks/<id>/status API endpoint was previously deprecated in favor of GET /api/requests/<rq_id>
Extracted from #9075

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17 Marishka17 requested a review from nmanovic as a code owner February 7, 2025 19:33
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (fec040d) to head (c3d1113).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9076      +/-   ##
===========================================
+ Coverage    73.75%   73.91%   +0.16%     
===========================================
  Files          428      428              
  Lines        44514    44498      -16     
  Branches      3881     3881              
===========================================
+ Hits         32830    32890      +60     
+ Misses       11684    11608      -76     
Components Coverage Δ
cvat-ui 77.44% <ø> (-0.03%) ⬇️
cvat-server 70.99% <ø> (+0.31%) ⬆️

@Marishka17
Copy link
Contributor Author

Before merging this PR, we need to switch the Exchange Oracle from Human Protocol to the requests API.
FYI: @zhiltsov-max

@SpecLad
Copy link
Contributor

SpecLad commented Feb 10, 2025

Before merging this PR, we need to switch the Exchange Oracle from Human Protocol to the requests API. FYI: @zhiltsov-max

I'll convert it to draft then, to prevent mistakes. Please convert it back when it's safe to merge.

@SpecLad SpecLad marked this pull request as draft February 10, 2025 11:04
Comment on lines 3528 to 3529
expected_task_creation_status_state='finished',
expected_task_creation_status_reason=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you could change "status" to "request"/"rq" here? Seems like it would match the terminology better.

@Marishka17 Marishka17 force-pushed the mk/drop_task_status_api branch from 98f02f3 to 5a343b1 Compare February 13, 2025 15:16
@Marishka17
Copy link
Contributor Author

/check

Copy link
Contributor

github-actions bot commented Feb 13, 2025

❌ Some checks failed
📄 See logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants