Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing proposal template in line with governance docs: specific changes for proposal #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mbernst
Copy link

@mbernst mbernst commented Dec 21, 2017

This pull request makes concrete the suggestions in the proposal "Change issue template to bring it in line with governance document". Please start there.

@mbernst
Copy link
Author

mbernst commented Dec 21, 2017

Cross-linking to proposal #27!


## My proposal
3. If you have a solution to this problem and you will implement it, continue, otherwise remove the **my proposal** section.
1. Add a proposal title above that concisely summarizes the problem or suggestion.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding the title after writing the problem (or proposal) leads to better titles. In the same way that writing a subject after writing an email leads to more informative subjects.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. I was mainly worried people would clear out all this text without getting that far down, and not read it.

4. Add yourself as an assignee to this proposal.
5. Replace this text with a clear statement of the solution you propose to implement, including any relevant supporting files. It can strengthen your proposal to include *pros* and *cons* and your thoughts about the *implications* (short and long term) of it being executed.
5. If this is a strategic milestone, add the `strategy` milestone.
6. If you have a solution to this problem and you will implement it, replace this text with a clear statement of the solution you propose to implement, including any relevant supporting files. It can strengthen your proposal to include *pros* and *cons*. If you have no solution, remove this Proposal section.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, ideally this should go before 4 as it is the first thing to do when deciding to make this a structured proposal instead of just reporting a problem.

6. If you have a solution to this problem and you will implement it, replace this text with a clear statement of the solution you propose to implement, including any relevant supporting files. It can strengthen your proposal to include *pros* and *cons*. If you have no solution, remove this Proposal section.

### Implications
7. Replace this text with short-term (and, if relevant, long-term) implications of executing this proposal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might add "long-term implications are required for strategic proposals", or something to that effect.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@mbernst
Copy link
Author

mbernst commented Dec 21, 2017

@markwhiting, feel free to make the changes directly. I added you as a collaborator to my forked repo.

### Implications
5. Replace this text with short-term (and, if relevant, long-term) implications of executing this proposal. If it is a strategy proposl, long-term implications are required.

## Contact

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now to make sure attributions are clear, let's change Contact heading to Person or People Who Added the Proposal to GitHub

With a asterisk note below
**The person who added the proposal to GitHub--- the name in this section doesn't indicate that the person came up with this idea, unless and until explicitly and clearly mentioned.

and then names
XYZ

Copy link

@shirishgoyal shirishgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is missing the changes that should reflect in "strategy" proposal. Other than that, it looks all fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants