Fix cases where cookie may have duplicate parameters #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a real-life case where dumb ASP.NET software managed to set two conflicting values for `SameSite` parameter. Such situation causes Cro::HTTP::Cookie to die. According to RFC 6265bis specs (or, at least, according to how ChatGPT interprets them since I got no time to read them in full), the standard parameters must not be repeated. If this is not the case then client software should either reject wrong-made cookie or use the first specified parameter. From the resilience perspective, the second approach is preferable.
|
This is looking good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a real-life case where dumb ASP.NET software managed to set two conflicting values for
SameSiteparameter. Such situation causes Cro::HTTP::Cookie to die.According to RFC 6265bis specs (or, at least, according to how ChatGPT interprets them since I got no time to read them in full), the standard parameters must not be repeated. If this is not the case then client software should either reject wrong-made cookie or use the first specified parameter. From the resilience perspective, the second approach is preferable.