Add flag to log to stdout #1669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Krause <[email protected]>
|
Thanks. Why is this extra flag necessary instead of just using shell’s redirection ( |
|
Changes LGTM |
|
A friendly reminder that this PR had no activity for 30 days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds a flag that allows users to configure if logrus logs to
stderr(the default) orstdout.Logrus currently cannot log to different locations based on the log levels and defaults to logging all levels to
stderr. This causes issues when systems are collecting these logs and reporting INFO logs as errors because they are logged tostderr. This provides a simple mechanism for changing that behavior.Signed-off-by: Noah Krause [email protected]