(not just) Makefile cleanups #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
makefile-cleanups
branch
from
34129da
to
3a1dbc3
Compare
|
LGTM |
This is no longer used since commit 3a122aa. [NO NEW TESTS NEEDED] Signed-off-by: Kir Kolyshkin <[email protected]>
Since commit c7937cd it is no longer necessary to have it. [NO NEW TESTS NEEDED] Signed-off-by: Kir Kolyshkin <[email protected]>
It looks like those were added to aim in CI, and is no longer required. As it is quite unexpected to have make targets operate on directories such as ../../, let's remove those. Fix Ubuntu build instructions accordingly (runc binary package is available in those distros). [NO NEW TESTS NEEDED] Signed-off-by: Kir Kolyshkin <[email protected]>
For quite some time (Go 1.16? To be honest, I don't remember) placing sources in a specific directory under $GOPATH is no longer required. [NO NEW TESTS NEEDED] Signed-off-by: Kir Kolyshkin <[email protected]>
[NO NEW TESTS NEEDED] Signed-off-by: Kir Kolyshkin <[email protected]>
It is cleaner that way. While at it, let's try to minimize it. [NO NEW TESTS NEEDED] Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
makefile-cleanups
branch
from
3a1dbc3
to
135431f
Compare
|
Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, Luap99, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Cleaning up parts of Makefile (and other relevant bits) that are no longer needed / obsolete.
Please see individual commits for details.