[wip] executor: resolve BuiltInArgs while expanding baseImage for dependencyInfo
#4839
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
rhatdan
changed the title
BultInArgs while expanding baseImage for dependencyInfoBultInArgs while expanding baseImage for dependencyInfo
rhatdan
changed the title
BultInArgs while expanding baseImage for dependencyInfoBuiltInArgs while expanding baseImage for dependencyInfo
|
Those globals don't change their values when |
Signed-off-by: Aditya R <[email protected]>
While creating a dependency map, executor must consider expanding base images with `builtInArgs` like `TARGETARCH, TARGETOS` etc so buildah can still keep and use the stages as dependency later on. Closes: containers#4820 Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
from-eval-default-args
branch
from
5fa4de4
to
ce3443b
Compare
|
A friendly reminder that this PR had no activity for 30 days. |
|
@flouthoc any update on this one? |
|
Just waiting for review on this one openshift/imagebuilder#258, let me bump there. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
A friendly reminder that this PR had no activity for 30 days. |
|
Waiting for this one openshift/imagebuilder#258 |
|
A friendly reminder that this PR had no activity for 30 days. |
While creating a dependency info and populating
baseMap, executor must consider expanding baseimages with
builtInArgslikeTARGETARCH, TARGETOSetc so buildah canstill keep and use the stages as dependency later on.
Closes: #4820
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?