-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary zot url env variable in ground control #74
base: main
Are you sure you want to change the base?
remove unnecessary zot url env variable in ground control #74
Conversation
WalkthroughThe pull request removes the ZOT_URL configuration variable from the ground-control/.env file. This deletion indicates that the application will no longer reference the ZOT Registry URL. All other settings, including those for the Source Registry, Ground Control PORT, and database connections, remain unchanged. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We don't use
ZOT_URL
in any part of ground control. In fact, only the satellite core communicates with Zot registry and it makes use ofconfig.json
to get the URL. This env variable can be safely removed.Summary by CodeRabbit