-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Windows library as shared #27
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
65a0fa2
to
bbdae08
Compare
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12601606464. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12605776726. Examine the logs at this URL for more detail. |
e5d2ac2
to
42f4840
Compare
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
f0de2f6
to
2d9f772
Compare
…onda-forge-pinning 2025.01.03.14.12.46
4c5b23b
to
a2642c6
Compare
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12606823231. Examine the logs at this URL for more detail. |
@traversaro Could you please take a look when you have a chance? Thanks! |
Thanks for working on this! Doing the switch static --> shared without a package version number is a bit brittle, as downstream package will have a run_exports of fcl 0.7.0 could be either a static library or a shared library. Anyhow, the shared library will have an higher build number, so hopefully we will be good to go.
It does not seem that the repo upstream is particularly active, so if nothing that changes the probability of upstream getting support for building shared libraries on Windows is quite low, right? |
@jeongseok-meta feel free to also add you as maintainer here if you like. |
That's a good point. I hope this doesn't cause significant downstream issues.
Unfortunately, I think so. I plan to continue maintaining the upstream FCL by resolving build issues, including shared build fixes, without adding new features. However, I don't have a specific timeline for this at the moment.. |
I'm already a maintainer, thanks to you! :D |
Ah great. :D |
This is a temporary solution until it's addressed in the upstream, such as flexible-collision-library/fcl#461. Until then, I've added a minimal patch to enable building as shared libraries on Windows. It has been tested by building and running the unit tests.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Closes #18