Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Windows library as shared #27

Merged
merged 4 commits into from
Jan 5, 2025

Conversation

jeongseok-meta
Copy link
Contributor

@jeongseok-meta jeongseok-meta commented Jan 3, 2025

This is a temporary solution until it's addressed in the upstream, such as flexible-collision-library/fcl#461. Until then, I've added a minimal patch to enable building as shared libraries on Windows. It has been tested by building and running the unit tests.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #18

@jeongseok-meta
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jeongseok-meta jeongseok-meta force-pushed the win_shared branch 2 times, most recently from 65a0fa2 to bbdae08 Compare January 3, 2025 15:07
@jeongseok-meta
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12601606464. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12605776726. Examine the logs at this URL for more detail.

@jeongseok-meta
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jeongseok-meta jeongseok-meta force-pushed the win_shared branch 6 times, most recently from f0de2f6 to 2d9f772 Compare January 4, 2025 01:37
@jeongseok-meta jeongseok-meta marked this pull request as ready for review January 4, 2025 02:41
@jeongseok-meta
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12606823231. Examine the logs at this URL for more detail.

@jeongseok-meta
Copy link
Contributor Author

@traversaro Could you please take a look when you have a chance? Thanks!

@traversaro
Copy link
Contributor

@traversaro Could you please take a look when you have a chance? Thanks!

Thanks for working on this! Doing the switch static --> shared without a package version number is a bit brittle, as downstream package will have a run_exports of fcl 0.7.0 could be either a static library or a shared library. Anyhow, the shared library will have an higher build number, so hopefully we will be good to go.

Until then, I've added a minimal patch to enable building as shared libraries on Windows.

It does not seem that the repo upstream is particularly active, so if nothing that changes the probability of upstream getting support for building shared libraries on Windows is quite low, right?

@traversaro traversaro merged commit 1f268fb into conda-forge:main Jan 5, 2025
10 checks passed
@traversaro
Copy link
Contributor

@jeongseok-meta feel free to also add you as maintainer here if you like.

@jeongseok-meta jeongseok-meta deleted the win_shared branch January 5, 2025 19:12
@jeongseok-meta
Copy link
Contributor Author

Doing the switch static --> shared without a package version number is a bit brittle, as downstream package will have a run_exports of fcl 0.7.0 could be either a static library or a shared library.

That's a good point. I hope this doesn't cause significant downstream issues.

It does not seem that the repo upstream is particularly active, so if nothing that changes the probability of upstream getting support for building shared libraries on Windows is quite low, right?

Unfortunately, I think so. I plan to continue maintaining the upstream FCL by resolving build issues, including shared build fixes, without adding new features. However, I don't have a specific timeline for this at the moment..

@jeongseok-meta
Copy link
Contributor Author

@jeongseok-meta feel free to also add you as maintainer here if you like.

I'm already a maintainer, thanks to you! :D

@traversaro
Copy link
Contributor

@jeongseok-meta feel free to also add you as maintainer here if you like.

I'm already a maintainer, thanks to you! :D

Ah great. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Windows library as shared
3 participants