Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Add how to package a system package using Conan #3978

Merged
merged 28 commits into from
Feb 4, 2025

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Feb 3, 2025

Hello!

This PR is related to conan-io/examples2#177

closes #3974

Current overview based on the commit f64f1f4

Screenshot 2025-02-04 at 15-33-01 Wrapping system requirements in a Conan package — conan 2 12 1 documentation

Signed-off-by: Uilian Ries <[email protected]>
@valgur
Copy link
Contributor

valgur commented Feb 3, 2025

Should the example also include a self.tool_requires("pkgconfig/...")? I guess it can be skipped to keep things simple.

@uilianries
Copy link
Member Author

Should the example also include a self.tool_requires("pkgconfig/...")? I guess it can be skipped to keep things simple.

It should be as simple as possible, so yes, skipping tool_requires will be better. Thank you for reviewing.

uilianries and others added 2 commits February 3, 2025 12:47
Co-authored-by: Carlos Zoido <[email protected]>
Co-authored-by: Carlos Zoido <[email protected]>
examples/tools/system/package_manager.rst Outdated Show resolved Hide resolved
examples/tools/system/package_manager.rst Outdated Show resolved Hide resolved
examples/tools/system/package_manager.rst Outdated Show resolved Hide resolved
examples/tools/system/package_manager.rst Outdated Show resolved Hide resolved
Signed-off-by: Uilian Ries <[email protected]>
examples/tools/system/package_manager.rst Outdated Show resolved Hide resolved
examples/tools/system/package_manager.rst Outdated Show resolved Hide resolved
examples/tools/system/package_manager.rst Outdated Show resolved Hide resolved
examples/tools/system/package_manager.rst Outdated Show resolved Hide resolved
examples/tools/system/package_manager.rst Outdated Show resolved Hide resolved
@czoido czoido requested a review from memsharded February 4, 2025 14:33
@czoido czoido merged commit 46e8eb4 into conan-io:develop2 Feb 4, 2025
2 checks passed
@uilianries uilianries deleted the examples/system-reqs-ncurses branch February 4, 2025 15:02
czoido added a commit that referenced this pull request Feb 4, 2025
* Add system package example

Signed-off-by: Uilian Ries <[email protected]>

* Do not package system libraries

Signed-off-by: Uilian Ries <[email protected]>

* Update example title

Signed-off-by: Uilian Ries <[email protected]>

* Add note about always running system_requirements

Signed-off-by: Uilian Ries <[email protected]>

* Update examples/tools/system/package_manager.rst

Co-authored-by: Carlos Zoido <[email protected]>

* Update examples/tools/system/package_manager.rst

Co-authored-by: Carlos Zoido <[email protected]>

* Omit CI script

Signed-off-by: Uilian Ries <[email protected]>

* Grammar fix

Co-authored-by: Carlos Zoido <[email protected]>

* Update line description

Co-authored-by: Carlos Zoido <[email protected]>

* Synchronize example content

Signed-off-by: Uilian Ries <[email protected]>

* Update examples/tools/system/package_manager.rst

Co-authored-by: Abril Rincón Blanco <[email protected]>

* Update examples/tools/system/package_manager.rst

Co-authored-by: Abril Rincón Blanco <[email protected]>

* Update examples/tools/system/package_manager.rst

Co-authored-by: Abril Rincón Blanco <[email protected]>

* Update examples/tools/system/package_manager.rst

Co-authored-by: Abril Rincón Blanco <[email protected]>

* Update consumer source code according to the example

Signed-off-by: Uilian Ries <[email protected]>

* Improve illustration message

Signed-off-by: Uilian Ries <[email protected]>

* Add support for FreeBSD

Signed-off-by: Uilian Ries <[email protected]>

* Use official cmake targets for ncurses

Signed-off-by: Uilian Ries <[email protected]>

* Only run example for supported OS

Signed-off-by: Uilian Ries <[email protected]>

* Update examples/tools/system/package_manager.rst

Co-authored-by: Carlos Zoido <[email protected]>

* Better conanfile description

Co-authored-by: James <[email protected]>

* grammar: packaging to wrapping

Co-authored-by: James <[email protected]>

* grammar: illustration to example

Signed-off-by: Uilian Ries <[email protected]>

* Update app execution according to the example

Signed-off-by: Uilian Ries <[email protected]>

* Explain about wrapping sys package information

Signed-off-by: Uilian Ries <[email protected]>

* Add official FindCurses reference

Signed-off-by: Uilian Ries <[email protected]>

* Use executable path instead of running the app

Signed-off-by: Uilian Ries <[email protected]>

---------

Signed-off-by: Uilian Ries <[email protected]>
Co-authored-by: Carlos Zoido <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>
Co-authored-by: James <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[example] Add how to package a system requirement as new example
5 participants