-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Add how to package a system package using Conan #3978
Merged
czoido
merged 28 commits into
conan-io:develop2
from
uilianries:examples/system-reqs-ncurses
Feb 4, 2025
Merged
[examples] Add how to package a system package using Conan #3978
czoido
merged 28 commits into
conan-io:develop2
from
uilianries:examples/system-reqs-ncurses
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Should the example also include a |
memsharded
reviewed
Feb 3, 2025
It should be as simple as possible, so yes, skipping tool_requires will be better. Thank you for reviewing. |
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
czoido
reviewed
Feb 3, 2025
czoido
reviewed
Feb 3, 2025
czoido
reviewed
Feb 3, 2025
Co-authored-by: Carlos Zoido <[email protected]>
Co-authored-by: Carlos Zoido <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
czoido
reviewed
Feb 3, 2025
czoido
reviewed
Feb 3, 2025
czoido
reviewed
Feb 3, 2025
Co-authored-by: Carlos Zoido <[email protected]>
Co-authored-by: Carlos Zoido <[email protected]>
czoido
reviewed
Feb 3, 2025
czoido
reviewed
Feb 3, 2025
AbrilRBS
reviewed
Feb 3, 2025
Signed-off-by: Uilian Ries <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>
…conan-docs into examples/system-reqs-ncurses
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
czoido
reviewed
Feb 3, 2025
czoido
reviewed
Feb 4, 2025
memsharded
reviewed
Feb 4, 2025
Co-authored-by: Carlos Zoido <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
czoido
reviewed
Feb 4, 2025
Signed-off-by: Uilian Ries <[email protected]>
czoido
approved these changes
Feb 4, 2025
czoido
added a commit
that referenced
this pull request
Feb 4, 2025
* Add system package example Signed-off-by: Uilian Ries <[email protected]> * Do not package system libraries Signed-off-by: Uilian Ries <[email protected]> * Update example title Signed-off-by: Uilian Ries <[email protected]> * Add note about always running system_requirements Signed-off-by: Uilian Ries <[email protected]> * Update examples/tools/system/package_manager.rst Co-authored-by: Carlos Zoido <[email protected]> * Update examples/tools/system/package_manager.rst Co-authored-by: Carlos Zoido <[email protected]> * Omit CI script Signed-off-by: Uilian Ries <[email protected]> * Grammar fix Co-authored-by: Carlos Zoido <[email protected]> * Update line description Co-authored-by: Carlos Zoido <[email protected]> * Synchronize example content Signed-off-by: Uilian Ries <[email protected]> * Update examples/tools/system/package_manager.rst Co-authored-by: Abril Rincón Blanco <[email protected]> * Update examples/tools/system/package_manager.rst Co-authored-by: Abril Rincón Blanco <[email protected]> * Update examples/tools/system/package_manager.rst Co-authored-by: Abril Rincón Blanco <[email protected]> * Update examples/tools/system/package_manager.rst Co-authored-by: Abril Rincón Blanco <[email protected]> * Update consumer source code according to the example Signed-off-by: Uilian Ries <[email protected]> * Improve illustration message Signed-off-by: Uilian Ries <[email protected]> * Add support for FreeBSD Signed-off-by: Uilian Ries <[email protected]> * Use official cmake targets for ncurses Signed-off-by: Uilian Ries <[email protected]> * Only run example for supported OS Signed-off-by: Uilian Ries <[email protected]> * Update examples/tools/system/package_manager.rst Co-authored-by: Carlos Zoido <[email protected]> * Better conanfile description Co-authored-by: James <[email protected]> * grammar: packaging to wrapping Co-authored-by: James <[email protected]> * grammar: illustration to example Signed-off-by: Uilian Ries <[email protected]> * Update app execution according to the example Signed-off-by: Uilian Ries <[email protected]> * Explain about wrapping sys package information Signed-off-by: Uilian Ries <[email protected]> * Add official FindCurses reference Signed-off-by: Uilian Ries <[email protected]> * Use executable path instead of running the app Signed-off-by: Uilian Ries <[email protected]> --------- Signed-off-by: Uilian Ries <[email protected]> Co-authored-by: Carlos Zoido <[email protected]> Co-authored-by: Abril Rincón Blanco <[email protected]> Co-authored-by: James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR is related to conan-io/examples2#177
closes #3974
Current overview based on the commit f64f1f4