feat: show the proper message in the custom picker when all images are either uploaded or marked.

[yuvraj-coder1]

Fixes #5619

Added a message "Congratulations, all pictures in this album have been either uploaded or marked as not for upload" in the custom image picker when the user have either uploaded or marked all the images in an album.

Tests performed

Tested ProdDebug on Vivo2334 with API level 34.

Screenshots (for UI changes only)

WhatsApp.Video.2025-01-02.at.16.50.04_37e0bc04.mp4

[Sujal-Gupta-SG]

@nicolas-raoul

Review by GSoC applicant

• Issue before merging

Record_2025-01-02-21-37-59.mp4

• Issue after merging

Record_2025-01-02-21-56-17.mp4

Tests performed (required)

Tested on:

• Build variant: ProdDebug
• Device: Realme Narzo 20
• API Level: 30-ext15

---

Result: The issue was resolved after merging the pull request.

[yuvraj-coder1]

Review by GSoC applicant

Hi @yuvraj-coder1 ,

I noticed that you're working on #5619 issue, but it hasn’t been assigned to you yet. To ensure proper collaboration and avoid duplicate efforts, it’s important to first ask for the issue to be assigned to you.

You can comment on the issue with something like: "Hi, can you please assign this issue to me? I’d like to work on it as part of my contributions."

Once the issue is assigned to you, you can proceed with your implementation

hi @Sujal-Gupta-SG ,
I believe there might be a misunderstanding, as the issue (#5619) has already been assigned to me.

[neeldoshii]

Discussion :
Just as an enhancement discussion (we can add this once this is merged). Displaying only text addresses the core problem but can feel a bit stark with the rest of the screen being completely empty. We could explore options like adding a supporting graphic, a hint of color, or even a small interactive element to make it more visually cohesive. WDYT

• Ref comment : Add label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload." #5619 (comment)

Maybe it could even suggest the user to perform peer reviews or go take nearby pictures, with buttons to launch these activities.

Also a CTA leading to perform peer reviews would also be best.

[yuvraj-coder1]

Discussion : Just as an enhancement discussion (we can add this once this is merged). Displaying only text addresses the core problem but can feel a bit stark with the rest of the screen being completely empty. We could explore options like adding a supporting graphic, a hint of color, or even a small interactive element to make it more visually cohesive. WDYT

• Ref comment : Add label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload." #5619 (comment)

Maybe it could even suggest the user to perform peer reviews or go take nearby pictures, with buttons to launch these activities.

Also a CTA leading to perform peer reviews would also be best.

Thank you for the suggestion, I agree that adding a supporting graphic would enhance the visual appeal and make the screen feel more engaging. I'll explore options for incorporating one above the text.

As for the CTA related to peer reviews, could you clarify a bit further?

[Sujal-Gupta-SG]

Review by GSoC applicant

I think the changes is Great

[nicolas-raoul]

Would you mind checking this unit test?

ImageFragmentTest > testOnCreateView FAILED
    java.lang.IllegalStateException at ImageFragmentTest.kt:124

[nicolas-raoul]

In a folder which contains both actioned and actionable pictures, when I disable Show already actioned pictures I briefly see the congratulation message before the actionable pictures get shown.

Would you mind showing the congratulation message only once we are sure there are no picture to show?

Thanks! :-)

[nicolas-raoul]

Working great!
I just left two minor things.

[nicolas-raoul]

Thanks! :-)