Log repostore timings #1065
Open
Log repostore timings #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following a chat with Giuliano, we agreed that information of this kind of much more useful as a metric than as log entry parameters. The log entries might be useful for testing/benchmarking. But from a node-operator point of view, the metrics are much more useful. We found that the default collector types are not useful in this case, so a StatSummary type was set up following the example of custom collectors from the metrics library. I bet it'll be useful in other cases as well. (Block retrieval time comes to mind!) Question is: Is it worth removing the log parameter? It doesn't really cost anything to have it. |
benbierens
added
the
Client
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Ben Bierens <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Ben Bierens <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Ben Bierens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a quick and easy way to keep an eye on repostore performance.
Hidden behind a compile flag, enabled in the dist-test images by default.
This can be used to automatically check on the disk IO performance in cluster-test scenarios.