Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache rollup task serialization #872

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

there's an error where the cursor of the serialized table BytesIO is not at the start which causes it to fail writing to GCP, this fixes that

there's an error where the cursor of the serialized table BytesIO is not
at the start which causes it to fail writing to GCP, this fixes that
@joseph-sentry joseph-sentry requested a review from a team November 8, 2024 23:43
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (6844106) to head (00318ab).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35464    +1     
=======================================
+ Hits        34731    34732    +1     
  Misses        732      732           
Flag Coverage Δ
integration 41.99% <0.00%> (-0.01%) ⬇️
unit 90.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 94.87% <100.00%> (+0.13%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35464    +1     
=======================================
+ Hits        34731    34732    +1     
  Misses        732      732           
Flag Coverage Δ
integration 41.99% <0.00%> (-0.01%) ⬇️
unit 90.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 94.87% <100.00%> (+0.13%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (6844106) to head (00318ab).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35464    +1     
=======================================
+ Hits        34731    34732    +1     
  Misses        732      732           
Flag Coverage Δ
integration 41.99% <0.00%> (-0.01%) ⬇️
unit 90.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 94.87% <100.00%> (+0.13%) ⬆️

Copy link

codecov-public-qa bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (6844106) to head (00318ab).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35464    +1     
=======================================
+ Hits        34731    34732    +1     
  Misses        732      732           
Flag Coverage Δ
integration 41.99% <0.00%> (-0.01%) ⬇️
unit 90.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.63% <ø> (ø)
Files Coverage Δ
tasks/cache_test_rollups.py 94.87% <100.00%> (+0.13%) ⬆️

Copy link

github-actions bot commented Nov 8, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit ccd0eb9 Nov 11, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-cache-tasks branch November 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants