Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for "reuse_db" test functionality #870

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

michelletran-codecov
Copy link
Contributor

This also fixes an issue with the test_postgres_sqlalchemy teardown if we don't want to keep the DB.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

This was breaking if we use `reuse-db` option to bootstrap the DB.
Also fixed teardown for `test_postgres_sqlalchemy`.
This was not getting torn down properly (`test_postgres_django` was being torn down twice).
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.93%. Comparing base (dbd2417) to head (b8d941e).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
conftest.py 90.47% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35468    +5     
=======================================
+ Hits        34731    34736    +5     
  Misses        732      732           
Flag Coverage Δ
integration 42.00% <90.47%> (+<0.01%) ⬆️
unit 90.68% <90.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (ø)
OutsideTasks 95.63% <90.47%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
conftest.py 95.00% <90.47%> (+0.14%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
conftest.py 90.47% 2 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35468    +5     
=======================================
+ Hits        34731    34736    +5     
  Misses        732      732           
Flag Coverage Δ
integration 42.00% <90.47%> (+<0.01%) ⬆️
unit 90.68% <90.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (ø)
OutsideTasks 95.63% <90.47%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
conftest.py 95.00% <90.47%> (+0.14%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.93%. Comparing base (dbd2417) to head (b8d941e).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
conftest.py 90.47% 2 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35468    +5     
=======================================
+ Hits        34731    34736    +5     
  Misses        732      732           
Flag Coverage Δ
integration 42.00% <90.47%> (+<0.01%) ⬆️
unit 90.68% <90.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (ø)
OutsideTasks 95.63% <90.47%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
conftest.py 95.00% <90.47%> (+0.14%) ⬆️

Copy link

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.93%. Comparing base (dbd2417) to head (b8d941e).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35468    +5     
=======================================
+ Hits        34731    34736    +5     
  Misses        732      732           
Flag Coverage Δ
integration 42.00% <90.47%> (+<0.01%) ⬆️
unit 90.68% <90.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (ø)
OutsideTasks 95.63% <90.47%> (+<0.01%) ⬆️
Files Coverage Δ
conftest.py 95.00% <90.47%> (+0.14%) ⬆️

Copy link

github-actions bot commented Nov 8, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@michelletran-codecov michelletran-codecov marked this pull request as ready for review November 8, 2024 18:51
@michelletran-codecov michelletran-codecov requested a review from a team November 8, 2024 18:51
Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding back support for this flag ❤️

@michelletran-codecov michelletran-codecov added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 0d58119 Nov 12, 2024
24 of 27 checks passed
@michelletran-codecov michelletran-codecov deleted the fix_db_test_issues branch November 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants