-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for "reuse_db" test functionality #870
Conversation
This was breaking if we use `reuse-db` option to bootstrap the DB.
Also fixed teardown for `test_postgres_sqlalchemy`. This was not getting torn down properly (`test_postgres_django` was being torn down twice).
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 444 444
Lines 35463 35468 +5
=======================================
+ Hits 34731 34736 +5
Misses 732 732
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #870 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 444 444
Lines 35463 35468 +5
=======================================
+ Hits 34731 34736 +5
Misses 732 732
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #870 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 444 444
Lines 35463 35468 +5
=======================================
+ Hits 34731 34736 +5
Misses 732 732
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #870 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 444 444
Lines 35463 35468 +5
=======================================
+ Hits 34731 34736 +5
Misses 732 732
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding back support for this flag ❤️
This also fixes an issue with the
test_postgres_sqlalchemy
teardown if we don't want to keep the DB.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.