Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode and cleanup intermediate_reports_in_redis feature #866

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Nov 8, 2024

The feature has been fully rolled out by now, so it is time to clean up the transitional code.

@Swatinem Swatinem requested a review from a team November 8, 2024 11:23
@Swatinem Swatinem self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.92%. Comparing base (742e89c) to head (532d6ed).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/processing/intermediate.py 92.59% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files         444      444              
  Lines       35463    35424      -39     
==========================================
- Hits        34731    34689      -42     
- Misses        732      735       +3     
Flag Coverage Δ
integration 97.92% <93.75%> (-0.02%) ⬇️
unit 97.92% <93.75%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <93.75%> (-0.04%) ⬇️
OutsideTasks 97.96% <93.33%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
rollouts/__init__.py 100.00% <ø> (ø)
services/processing/processing.py 98.24% <100.00%> (+0.03%) ⬆️
tasks/tests/integration/test_upload_e2e.py 100.00% <ø> (ø)
tasks/tests/unit/test_upload_task.py 98.91% <ø> (ø)
tasks/upload.py 96.56% <ø> (-0.03%) ⬇️
tasks/upload_finisher.py 95.33% <100.00%> (-0.05%) ⬇️
tasks/upload_processor.py 92.00% <ø> (ø)
services/processing/intermediate.py 96.36% <92.59%> (-3.64%) ⬇️

... and 1 file with indirect coverage changes

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/processing/intermediate.py 92.59% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files         444      444              
  Lines       35463    35424      -39     
==========================================
- Hits        34731    34689      -42     
- Misses        732      735       +3     
Flag Coverage Δ
integration 97.92% <93.75%> (-0.02%) ⬇️
unit 97.92% <93.75%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <93.75%> (-0.04%) ⬇️
OutsideTasks 97.96% <93.33%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
rollouts/__init__.py 100.00% <ø> (ø)
services/processing/processing.py 98.24% <100.00%> (+0.03%) ⬆️
tasks/tests/integration/test_upload_e2e.py 100.00% <ø> (ø)
tasks/tests/unit/test_upload_task.py 98.91% <ø> (ø)
tasks/upload.py 96.56% <ø> (-0.03%) ⬇️
tasks/upload_finisher.py 95.33% <100.00%> (-0.05%) ⬇️
tasks/upload_processor.py 92.00% <ø> (ø)
services/processing/intermediate.py 96.36% <92.59%> (-3.64%) ⬇️

... and 1 file with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.92%. Comparing base (742e89c) to head (532d6ed).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/processing/intermediate.py 92.59% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files         444      444              
  Lines       35463    35424      -39     
==========================================
- Hits        34731    34689      -42     
- Misses        732      735       +3     
Flag Coverage Δ
integration 97.92% <93.75%> (-0.02%) ⬇️
unit 97.92% <93.75%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <93.75%> (-0.04%) ⬇️
OutsideTasks 97.96% <93.33%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
rollouts/__init__.py 100.00% <ø> (ø)
services/processing/processing.py 98.24% <100.00%> (+0.03%) ⬆️
tasks/tests/integration/test_upload_e2e.py 100.00% <ø> (ø)
tasks/tests/unit/test_upload_task.py 98.91% <ø> (ø)
tasks/upload.py 96.56% <ø> (-0.03%) ⬇️
tasks/upload_finisher.py 95.33% <100.00%> (-0.05%) ⬇️
tasks/upload_processor.py 92.00% <ø> (ø)
services/processing/intermediate.py 96.36% <92.59%> (-3.64%) ⬇️

... and 1 file with indirect coverage changes

Copy link

codecov-public-qa bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.92%. Comparing base (742e89c) to head (532d6ed).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files         444      444              
  Lines       35463    35424      -39     
==========================================
- Hits        34731    34689      -42     
- Misses        732      735       +3     
Flag Coverage Δ
integration 97.92% <93.75%> (-0.02%) ⬇️
unit 97.92% <93.75%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <93.75%> (-0.04%) ⬇️
OutsideTasks 97.96% <93.33%> (-0.02%) ⬇️
Files Coverage Δ
rollouts/__init__.py 100.00% <ø> (ø)
services/processing/processing.py 98.24% <100.00%> (+0.03%) ⬆️
tasks/tests/integration/test_upload_e2e.py 100.00% <ø> (ø)
tasks/tests/unit/test_upload_task.py 98.91% <ø> (ø)
tasks/upload.py 96.56% <ø> (-0.03%) ⬇️
tasks/upload_finisher.py 95.33% <100.00%> (-0.05%) ⬇️
tasks/upload_processor.py 92.00% <ø> (ø)
services/processing/intermediate.py 96.36% <92.59%> (-3.64%) ⬇️

... and 1 file with indirect coverage changes

Base automatically changed from swatinem/cleanup-flags to main November 8, 2024 11:31
@Swatinem Swatinem marked this pull request as ready for review November 8, 2024 12:13
The feature has been fully rolled out by now, so it is time to clean up the transitional code.
@Swatinem Swatinem added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 95d1a40 Nov 11, 2024
15 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/cleanup-store-redis branch November 11, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants