-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Receive user name for new Terms of Service UI #1094
base: main
Are you sure you want to change the base?
Conversation
2a07b3a
to
adea2a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. Additional details and impacted files@@ Coverage Diff @@
## main #1094 +/- ##
=======================================
Coverage 96.09% 96.10%
=======================================
Files 832 832
Lines 19507 19527 +20
=======================================
+ Hits 18746 18766 +20
Misses 761 761
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
codecov_auth/commands/owner/interactors/save_terms_agreement.py
Outdated
Show resolved
Hide resolved
f322a0d
to
f28e35c
Compare
f28e35c
to
dbaad07
Compare
ace77db
to
d045615
Compare
Purpose/Motivation
What is the feature? Why is this being done?
New onboarding changes for pre-PAT appless to make it easier and more clear for users to sign up. We are changing up the required information that a user must fill out to complete onboarding. We will no longer be asking for customer intent and for the user to select a default organization in step that follows this screen.
Links to relevant tickets
codecov/engineering-team#3174
Changes related to the UI changes designated in this Figma: https://www.figma.com/design/SsoxtY2SB73l0wiLbJ8FhZ/GH-2092?node-id=2288-16704&t=sMCRUMT3J1bwIct1-1
What does this PR do?
For the onboarding page, we are:
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.