tablemetadatacache: cleanup batch iterator query #139349
Open
+139
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scanning `system.namespace` entries for the table metadata update job, we were using LEFT JOIN to join parent and schema ids in system.namespace entries with their `name` column, also in system.namespace. It's seemingly possible that unknown schema failures can put us in a state where there may not be name entries for all schema ids present in `system.namespace`. This leads to `NULL` results for schemaName and cols, something the results handler was not anticipating. These should really be inner joins since we cannot fetch stats for any entries unable provide a fully qualified name. Epic: none Fixes: cockroachdb#139293 Release note: None
This commit removes the CTE in the table metadata batch iterator as it does not provide much value. Epic: none Release note: None
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note only the latest commit is for review.
This commit removes the CTE in the table metadata batch iterator
as it does not provide much value.
Epic: none
Release note: None