Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] Small fix for horizontal-scaling.md #3241

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

shurup
Copy link
Collaborator

@shurup shurup commented Jul 24, 2024

Describe your changes

Fixing the wrong statement that adding 4 x 4GB RAM nodes to a system of 4GB RAM will result in having 16GB RAM (it'll be 20GB then). I'm also removing a link to the Nodes article since this word was already linked in the previous paragraph.

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Copy link

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 7798060
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/66a091d720e5c20008bdac71
😎 Deploy Preview https://deploy-preview-3241--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @shurup but why did you remove the link to the nodes term?

@shurup
Copy link
Collaborator Author

shurup commented Aug 28, 2024

Hi @iamNoah1! As I noticed, due to a repeated link in this article, I don't think it's necessary. Please let me know if I'm wrong.

I'm also removing a link to the Nodes article since this word was already linked in the previous paragraph.

@iamNoah1
Copy link
Collaborator

Hi @iamNoah1! As I noticed, due to a repeated link in this article, I don't think it's necessary. Please let me know if I'm wrong.

I'm also removing a link to the Nodes article since this word was already linked in the previous paragraph.

@shurup makes sense :)

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @shurup

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seokho-son seokho-son merged commit df7b647 into cncf:main Aug 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
Development

Successfully merging this pull request may close these issues.

3 participants