-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[en] Small fix for horizontal-scaling.md #3241
Conversation
Signed-off-by: Dmitry Shurupov <[email protected]>
To see where this is in the review pipeline and follow the progress, please look at the definition review board. |
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @shurup but why did you remove the link to the nodes term?
Hi @iamNoah1! As I noticed, due to a repeated link in this article, I don't think it's necessary. Please let me know if I'm wrong.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @shurup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Describe your changes
Fixing the wrong statement that adding 4 x 4GB RAM nodes to a system of 4GB RAM will result in having 16GB RAM (it'll be 20GB then). I'm also removing a link to the Nodes article since this word was already linked in the previous paragraph.
Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.