Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace developer-guy with rwxdash as TR approver #2629

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

developer-guy
Copy link

Describe your changes

I'm stepping down from my role in the Turkish glossary team since I was not an active member of the community so I believe @rwxdash will be more active than I'm.

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 173d79a
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6555029f0e9caf0008bcfa61
😎 Deploy Preview https://deploy-preview-2629--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aliok
Copy link
Member

aliok commented Nov 15, 2023

Thanks @developer-guy for all the work you've done and we appreciate that you're stepping down to make other folks in the group recognized. We know you will be around and contribute but not as the same capacity; and that's totally ok.

We've already talked this in the group, but for double check: cc @halil-bugol @eminalemdar @rwxdash

cc @seokho-son

@ydFu ydFu added maintainers Use this label if PR requires maintainers to take action lang/tr for Turkish labels Nov 16, 2023
@seokho-son
Copy link
Collaborator

Thank you, @developer-guy, for your contributions so far! (Feel free to come back whenever you're available!)

Hello @rwxdash, I'd like to confirm if you are willing to accept this nomination.

If you agree, please review and confirm the following policies:
Policies for Localization Approvers (to be confirmed by candidates) #723

Once you have reviewed them, kindly leave a comment on this PR to indicate your confirmation.

@rwxdash
Copy link
Collaborator

rwxdash commented Nov 17, 2023

Hey @seokho-son.

I have read and understood the policies. Happy to take over @developer-guy's responsibilities. Thank you, again, for your contributions @developer-guy!

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work @developer-guy, and welcome @rwxdash, thanks for volunteering to help!

@seokho-son
Copy link
Collaborator

Thanks! I am going to create another PR to cncf/people to apply this change. (after that I am going to merge this PR)

@seokho-son
Copy link
Collaborator

ref cncf/people#325

@seokho-son seokho-son merged commit c9a3737 into cncf:main Nov 20, 2023
@aliok aliok deleted the 2023-11-15-update-tr-approver branch January 12, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tr for Turkish maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants