Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] Update Vertical Scaling #2590

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

ydFu
Copy link
Collaborator

@ydFu ydFu commented Nov 8, 2023

Describe your changes

According to the guidelines outlined in the style guide: When used in your definition, always link to existing glossary terms (only the first mention should be hyperlinked).
In light of this, I have identified two instances of repeated hyperlinks to "horizontal scaling" within this article. Consequently, I have initiated this pull request to eliminate the redundant links, thereby maintaining the overall conciseness of the article.

Related issue number or link (ex: resolves #issue-number)

CNCF Style Guide:
https://glossary.cncf.io/style-guide/#keeping-it-simple

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 587ad37
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/654b263cb3b30e0008593940
😎 Deploy Preview https://deploy-preview-2590--cncfglossary.netlify.app/vertical-scaling
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 8, 2023

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ydFu, good catch!

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seokho-son seokho-son merged commit 2761d8d into cncf:main Dec 4, 2023
7 checks passed
@ydFu ydFu deleted the en-update-vertical-scaling branch December 4, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
Development

Successfully merging this pull request may close these issues.

3 participants