-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass experimental_serve_directly
to vitest
#7773
base: main
Are you sure you want to change the base?
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-wrangler-7773 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7773/npm-package-wrangler-7773 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-wrangler-7773 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-cloudflare-workers-bindings-extension-7773 -O ./cloudflare-workers-bindings-extension.0.0.0-va57a14a2f.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va57a14a2f.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-create-cloudflare-7773 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-cloudflare-kv-asset-handler-7773 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-miniflare-7773 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-cloudflare-pages-shared-7773 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-cloudflare-unenv-preset-7773 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-cloudflare-vitest-pool-workers-7773 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-cloudflare-workers-editor-shared-7773 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-cloudflare-workers-shared-7773 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12786800592/npm-package-cloudflare-workflows-shared-7773 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a test to the vitest-pool-workers fixture?
options.miniflare.assets = { | ||
...options.miniflare.assets, | ||
routingConfig: { | ||
...options.miniflare.assets.routingConfig, | ||
has_user_worker: Boolean(options.main), | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Would it be simpler to modify the config directly?, e.g.
options.miniflare.assets = { | |
...options.miniflare.assets, | |
routingConfig: { | |
...options.miniflare.assets.routingConfig, | |
has_user_worker: Boolean(options.main), | |
}, | |
}; | |
options.miniflare.assets.routingConfig ??= {}; | |
options.miniflare.assets.routingConfig.has_user_worker = Boolean(options.main); |
Fixes WC-3076