Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated email regex. #38

Closed
wants to merge 5 commits into from
Closed

Updated email regex. #38

wants to merge 5 commits into from

Conversation

Ryanb58
Copy link

@Ryanb58 Ryanb58 commented Jun 13, 2018

Utilized this one..

http://emailregex.com/

@wojcikstefan
Copy link
Member

Thanks for this @Ryanb58! See the latest state of #36. It seems that this PR doesn't cover the [email protected] case.

@Ryanb58
Updated with an extra assertion.
3106fd8 
Assert an email with consecutivedots is also invalid.
@Ryanb58
Copy link
Author

Ryanb58 commented Jun 26, 2018

@wojcikstefan My last commit should fix that. How can I trigger tests?

@thomasst
Copy link
Member

thomasst commented Sep 2, 2019

Thanks! Closing this since I just merged #36 , but keeping #37 open to keep track of any other email validation issues.

@thomasst thomasst closed this Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryanb58 @wojcikstefan @thomasst