Use platform-independent newline separator in reporting

clj-commons · Feb 11, 2018 · 4a04da2 · 4a04da2 · voytech · Feb 11, 2018
1 parent c2d5e48
commit 4a04da2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/kibit/src/kibit/reporters.clj b/kibit/src/kibit/reporters.clj
@@ -22,14 +22,14 @@
     (->> (str string-writer)
          string/split-lines
          (map #(str "  " %))
-         (string/join "\n")
+         (string/join (System/getProperty "line.separator"))
          println)))
 
 (defn cli-reporter
   "Print a check-map to `*out*` in plain text."
   [check-map]
   (let [{:keys [file line expr alt]} check-map]
-    (printf "At %s:%s:\nConsider using:\n" file line)
+    (printf "At %s:%s:%nConsider using:%n" file line)
     (pprint-code alt)
     (println "instead of:")
     (pprint-code expr)
@@ -39,7 +39,7 @@
   "Print a check-map to `*out*` in github flavored markdown."
   [check-map]
   (let [{:keys [file line expr alt]} check-map]
-    (printf "----\n##### `%s:%s`\nConsider using:\n" file line)
+    (printf "----%n##### `%s:%s`%nConsider using:%n" file line)
     (println "```clojure")
     (pprint-code alt)
     (println "```")

diff --git a/kibit/test/kibit/test/reporters.clj b/kibit/test/kibit/test/reporters.clj
@@ -3,11 +3,6 @@
             [clojure.string :as string]
             [clojure.test :refer :all]))
 
-(defn- reported-lines [reporting]
-  (->> (clojure.string/split reporting #"\n")
-       (mapv #(clojure.string/replace % "\r" ""))
-       (filterv (complement clojure.string/blank?))))
-
 (deftest plain
   (are [check-map result]
        (= (with-out-str (reporters/cli-reporter check-map))