Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Extract code in bin/phpdoc-md into class #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

claytonrcarter
Copy link
Contributor

Nothing exciting here! This PR moves all of the code and logic from the bin script into a class, and updates the bin script to instantiate and call that class. Everything appears to be working and the example docs are generated with no changes.

I did add one very minor feature: the .phpdoc-md config file can return an object or an array.

Thanks!

Add feature: .phpdoc-md can return an object or an array
@Kage
Copy link
Collaborator

Kage commented Oct 18, 2018

+1

This helps to resolve #8

@Kage
Copy link
Collaborator

Kage commented Oct 18, 2018

However, I would recommend making the file operations optional (default enabled). That way you can feed data into and out of the command to test it without actually creating or accessing any files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants