invoke: preserve line numbers during helper methods #111
+73
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoking a helper function (or "auxiliary method", in the documentation), we lose the file/function/line information of the current call point. This means that we attribute failures to the helper function instead of the actual test. Provide a `cl_invoke` function that will preserve the current state. This allows callers to use the simpler "clar style" as documented, but get the correct failure location.
ethomson
force-pushed
the
ethomson/invoke
branch
from
57f5d2c to
baa977e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking a helper function (or "auxiliary method", in the documentation), we lose the file/function/line information of the current call point. This means that we attribute failures to the helper function instead of the actual test.
Provide a
cl_invokefunction that will preserve the current state. This allows callers to use the simpler "clar style" as documented, but get the correct failure location.