Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for frontend AfformTokens being generated incorrectly #31801

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattwire
Copy link
Contributor

Overview

On WordPress when you use the Afform "MessageTokens" it doesn't always generate the correct URLs.

Before

URLs generated incorrectly depending on context

After

URLs generated correctly.

Technical Details

Example:

  1. Submit an Afform (with contact + activity) that is on the WordPress frontend (eg. embedded in a page): https://mysite.com/myfirstform.
  2. Trigger a CiviRule on "activity create" that sends an email containing a "Message Token" for another form: https://mysite.com/mysecondform.
  3. Review the sent email and see that the link to the form is not correct.

It looks like: https://mysite.com/myfirstform?civiwp=mysite.com/mysecondform&token=...
But should look like: https://mysite.com/mysecondform?token=...

This is because the tokens code detects the referrer form and uses that as the frontend_url which we don't want in this case because the forms are completely separate.

Comments

Adding this as draft because it's a hacky proof of concept using \Civi::$statics to pass context through. But we should do it a better way.

Copy link

civibot bot commented Jan 16, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant