Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use config file with CURL loader #53

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Dec 18, 2024

Description

fixes #52

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Signed-off-by: Severin Neumann <[email protected]>
@svrnm svrnm requested a review from a team as a code owner December 18, 2024 11:04
Copy link
Contributor

@noMoreCLI noMoreCLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm, as this is a breaking change. Can we have the option to pass the configuration either through an env variable OR through a config file? There might be deployment envs in the future, where passing a file is more challenging than an env variable (ECS or other container PaaS services come in mind)

@svrnm
Copy link
Member Author

svrnm commented Dec 18, 2024

@svrnm, as this is a breaking change. Can we have the option to pass the configuration either through an env variable OR through a config file? There might be deployment envs in the future, where passing a file is more challenging than an env variable (ECS or other container PaaS services come in mind)

See 7d930dd, I changed it such that it checks if the file exists and if so reads from it otherwise it will use environment variables (if available)

@noMoreCLI noMoreCLI merged commit c677b04 into main Dec 18, 2024
0 of 2 checks passed
noMoreCLI pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Make curl (and other) loader(s) work with configuration file
2 participants